Bluetooth pairing cancellation error handling #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,7 @@ export default function DiscoverReadersScreen() { | |||
| }, []); | |||
|
|
|||
| const handleConnectReader = async (reader: Reader.Type) => { | |||
| let error: StripeError; | |||
| let error: StripeError | undefined; | |||
There was a problem hiding this comment.
any reason not to just OR it with null? Also the syntax
let error?: StripeError | null;
will let it be undefined or null
There was a problem hiding this comment.
I swapped it out but StripeError | undefined is required by handleConnectBluetoothReader and handleConnectInternetReader so leaving as undefined
jdivock-stripe
approved these changes
Mar 3, 2022
arekkubaczkowski
pushed a commit
to arekkubaczkowski/stripe-terminal-react-native
that referenced
this pull request
Jun 29, 2022
* connectingReader reset on error * locationId required for connectBluetoothReader * code style * onUnexpectedReaderDisconnect sends didFinishDiscoveringReaders event * DiscoverReaders failure triggers navigation.goBack * typecheck * replacing undefined with null * back to undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #109 and #49
DiscoverReadersScreen.connectingReadergets reset on discovery errorlocationIdis required forconnectBluetoothReaderonUnexpectedReaderDisconnectsendsdidFinishDiscoveringReaderseventDiscoverReadersScreendiscovery failure triggersnavigation.goBack